ReflectionParameter::__construct(): switch @param to typehint
#16216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type is checked (though for values of the wrong type a `ReflectionException` is thrown rather than a `TypeError`), but the information about the required type is not provided to Reflection. Replace the `@param` comment with a real typehint so that the information is also available via Reflection.
mvorisek
reviewed
Oct 4, 2024
| @@ -638,8 +638,7 @@ class ReflectionParameter implements Reflector | |||
| /** @implementation-alias ReflectionClass::__clone */ | |||
| private function __clone(): void {} | |||
|
|
|||
| /** @param string|array|object $function */ | |||
| public function __construct($function, int|string $param) {} | |||
| public function __construct(string|array|object $function, int|string $param) {} | |||
There was a problem hiding this comment.
Is
php-src/ext/reflection/php_reflection.c
Line 2537 in 2501cad
There was a problem hiding this comment.
I don't think so, since it is still reached in
The parameter is still parsed via Z_PARAM_ZVAL, rather than enforcing the types as part of the parsing
|
@kocsismate Can you verify if this is ok? Edit: I guess the feedback will be similar as with GH-16218, we should have consistent errors for parameter parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type is checked (though for values of the wrong type a
ReflectionExceptionis thrown rather than aTypeError), but the information about the required type is not provided to Reflection. Replace the@paramcomment with a real typehint so that the information is also available via Reflection.